add decode kvsdb tool #2059
Merged
add decode kvsdb tool #2059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datelier
requested review from
a team,
kmrmt and
hlts2
and removed request for
a team
|
[CHATOPS:HELP] ChatOps commands.
|
Deploying with
|
| Latest commit: |
5e12307
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://14d1b97b.vald.pages.dev |
| Branch Preview URL: | https://feature-tools-kvsdb.vald.pages.dev |
kpango
reviewed
Jun 13, 2023
hack/tools/kvsdb/main.go
Outdated
| kvsdb.Set(k, id, 0) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
it would be better to add header.
kmrmt
requested changes
Jun 19, 2023
hack/tools/kvsdb/main.go
Outdated
Comment on lines
48
to
65
| f, _ = file.Open( | ||
| file.Join(*path, *kvsFileName), | ||
| os.O_RDONLY|os.O_SYNC, | ||
| fs.ModePerm, | ||
| ) | ||
| _ = gob.NewDecoder(f).Decode(&m) | ||
|
|
||
| // timestamp | ||
| mt := make(map[string]int64) | ||
| gob.Register(map[string]int64{}) | ||
| var ft *os.File | ||
| defer ft.Close() | ||
| ft, _ = file.Open( | ||
| file.Join(*path, *kvsTimestampFileName), | ||
| os.O_RDONLY|os.O_SYNC, | ||
| fs.ModePerm, | ||
| ) | ||
| _ = gob.NewDecoder(ft).Decode(&mt) |
There was a problem hiding this comment.
I think you should stop this program like below when it returns errors because there can be the case such as no permission.
And I think you should consider logging levels.
This suggestion is just idea.
Suggested change
| f, _ = file.Open( | |
| file.Join(*path, *kvsFileName), | |
| os.O_RDONLY|os.O_SYNC, | |
| fs.ModePerm, | |
| ) | |
| _ = gob.NewDecoder(f).Decode(&m) | |
| // timestamp | |
| mt := make(map[string]int64) | |
| gob.Register(map[string]int64{}) | |
| var ft *os.File | |
| defer ft.Close() | |
| ft, _ = file.Open( | |
| file.Join(*path, *kvsTimestampFileName), | |
| os.O_RDONLY|os.O_SYNC, | |
| fs.ModePerm, | |
| ) | |
| _ = gob.NewDecoder(ft).Decode(&mt) | |
| var err error | |
| f, err = file.Open( | |
| file.Join(*path, *kvsFileName), | |
| os.O_RDONLY|os.O_SYNC, | |
| fs.ModePerm, | |
| ) | |
| if err != nil { | |
| log.Fatal(err) | |
| } | |
| if err = gob.NewDecoder(f).Decode(&m); err != nil { | |
| log.Fatal(err) | |
| } | |
| // timestamp | |
| mt := make(map[string]int64) | |
| gob.Register(map[string]int64{}) | |
| var ft *os.File | |
| defer ft.Close() | |
| ft, err = file.Open( | |
| file.Join(*path, *kvsTimestampFileName), | |
| os.O_RDONLY|os.O_SYNC, | |
| fs.ModePerm, | |
| ) | |
| if err != nil { | |
| log.Fatal(err) | |
| } | |
| if err = gob.NewDecoder(ft).Decode(&mt); err != nil { | |
| log.Fatal(err) | |
| } |
hack/tools/kvsdb/main.go
Outdated
| s = append(s, []string{k, strconv.FormatUint(uint64(id), 10), "0"}) | ||
| } | ||
| if len(s)*int(unsafe.Sizeof("")) > 4e+6 { | ||
| w.WriteAll(s) |
There was a problem hiding this comment.
same as above
Suggested change
| w.WriteAll(s) | |
| if err = w.WriteAll(s); err != nil { | |
| log.Warn(err) | |
| } |
hack/tools/kvsdb/main.go
Outdated
| s = nil | ||
| } | ||
| } | ||
| w.WriteAll(s) |
There was a problem hiding this comment.
same as above
Suggested change
| w.WriteAll(s) | |
| if err = w.WriteAll(s); err != nil { | |
| log.Fatal(err) | |
| } |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
add decode kvsdb tool.
run example:
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: